c - runtime error after running bubble sort -


i'm trying write program bubble sorts array, every time run error pops up: runtime error: index 4 out of bounds type 'int [e]'

what issue here?

int main(void) {     printf("how many elements there in array?: ");     int e = get_int();      int array[e];      (int = 0; < e; i++) {         printf("insert element #%i: ", + 1);         array[i] = get_int();     }      (int = 0; < e - 1; e++) {         (int j = 0; j < e - - 1; j++) {             if (array[j] > array[j + 1]) {                 int swap = array[j];                 array[j] = array[j + 1];                 array[j + 1] = swap;             }         }     }     printf("\n"); }

besides error noted chqrlie, don't overcomplicate bubble sort (and it's buggy, it's considering contiguous indices). write (note inner loop optimized avoid processing "lower triangle" items twice):

for (int = 0; < e; i++) {     (int j = i+1; j < e; j++) {         if (array[j] > array[i]) {             int swap = array[j];             array[j] = array[i];             array[i] = swap;         }     } }

Comments

Post a Comment

Popular posts from this blog

python - Operations inside variables -

this question has answer here: evaluating mathematical expression in string 12 answers i want make python script finds maximum possible output using 2 operations. problem says there syntax error @ 2nd last line, in b in there. how can fix it? x = 0 = int(input("1st number:")) c = int(input("2nd number:" )) e = int(input("3rd number:" )) in range(4): if == 0: b = "+" elif == 1: b = "-" elif == 2: b = "/" else: b = "*" j in range(4): if j == 0: d = "+" elif j == 1: d = "-" elif j == 2: d = "/" else: d = "*" k = b c d e print(k) if you're after variables e on single line, couldn...
Read more

Generic Map Parameter java -

i having lot of methods of type: public static list<eduusers> getdetails(class c, map<string, integer> params) { list<eduusers> details = null; session session = hibernateutil.getsessionfactory().opensession(); transaction tx = null; try { tx = session.begintransaction(); criteria cr = session.createcriteria(c); (map.entry<string, integer> entry : params.entryset()) { cr.add(restrictions.eq(entry.getkey(), entry.getvalue())); } details = cr.list(); tx.commit(); } catch (exception asd) { log.debug(asd.getmessage()); if (tx != null) { tx.commit(); } } { session.close(); } return details; } i trying have generic method them , have written far: public static <t> list<t> getdetails(class<t> c, class<t> b) { l...
Read more

arrays - What causes a java.lang.ArrayIndexOutOfBoundsException and how do I prevent it? -

what arrayindexoutofboundsexception mean , how rid of it? here code sample triggers exception: string[] name = {"tom", "dick", "harry"}; for(int = 0; i<=name.length; i++) { system.out.print(name[i] +'\n'); } your first port of call should documentation explains reasonably clearly: thrown indicate array has been accessed illegal index. index either negative or greater or equal size of array. so example: int[] array = new int[5]; int boom = array[10]; // throws exception as how avoid it... um, don't that. careful array indexes. one problem people run thinking arrays 1-indexed, e.g. int[] array = new int[5]; // ... populate array here ... (int index = 1; index <= array.length; index++) { system.out.println(array[index]); } that miss out first element (index 0) , throw exception when index 5. valid indexes here 0-4 inclusive. correct, idiomatic for statement here be: for (int index = 0; index <...
Read more