javascript - ESLint Rule on React Component: Method Render expected no return value -
i can't life of me understand why want rule let alone means. want return here in render
export default class searchtabs extends component { render() { const { panels, selectedtab } = this.props; if (!panels || panels.length === 0) return; let filter = null; const tabs = panels.member.map((panel, idx) => { const { id: panelid, headline } = panel; const url = getheaderlogo(panel, 50); const item = url ? <img src={url} alt={headline} /> : headline; const classname = classnames([ searchresultstheme.tabitem, (idx === selectedtab) ? searchresultstheme.active : null, ]); filter = (idx === selectedtab) ? this.renderfilters(panel) : filter; return ( <tabitem classname={`${classname} search-tab`} headline={headline} idx={idx} content={item} onclick={() => { this.tabchanged(idx, headline); }} panelid={panelid} /> ); }); return ( <div classname={searchresultstheme.filters}> <ul classname={`${searchresultstheme.tabs} ft-search-tabs`}>{tabs}</ul> <div classname={searchresultstheme.dropdown}>{filter}</div> </div> ); } }
i believe problem line
if (!panels || panels.length === 0) return;
it's complaining because code path not return anything. try changing to
if (!panels || panels.length === 0) return null;
Comments
Post a Comment