c - char *str[ ] pass by reference not working -


i passing char *str[] in function , adding contents in main function values unchanged.

from main calling lettercombinations function , calls function in editing valuees of char * str[] wwhihc changed there not reflected in letter combinations function

please me why not working

help(char *str[],char* curr,int index,char* digits,char** a,int *k)         {             if(strlen(curr)==strlen(digits))             {                 printf("%d",*k);                  str[*k]=(char*)malloc(strlen(digits)+1);                  str[*k]=curr;                 printf("%s %s %d\n",curr,str[*k],*k);                  *k=*k+1;                  return ;             }              int i;              char* loop=a[digits[index]-'0'];              int l=strlen(loop);             for(i=0;i<l;i++)             {                 curr[index]=loop[i];                  help(str,curr,index+1,digits,a,k);                 curr[index]='\0';             }         }   char** lettercombinations(char* digits, int* returnsize) {             char *str[100];               int i=0;             char* curr=malloc(sizeof(strlen(digits)+1));             char** a=(char**)malloc(10*sizeof(char*));           int siz=0;             a[0]="";             a[1]="";             a[2]="abc";             a[3]="def";             a[4]="ghi";             a[5]="jkl";             a[6]="mno";             a[7]="pqrs";             a[8]="tuv";             a[9]="wxyz";              help(str, curr, 0, digits,a,&siz);              printf("  %d",siz);             for(i=0;i<siz;i++)             {                 printf(" s   %s",str[i]);             }            // *returnsize=siz;             return str;             }

if compile code should see warnings such as:

warning c4172: returning address of local variable or temporary warning c4100: 'returnsize' : unreferenced formal parameter

returning address of local variable or temporary warning explains behaviour.

in code:

char** lettercombinations(char* digits, int* returnsize) {     char *str[100];    ...     return str; }

you create array on stack, str. when return lettercombinations, variable goes out of scope , stack memory location gets cleaned up. ie memory address used str no longer valid.

you change caller passes in own char* variable fix issue. alternatively, malloc str , when return function, memory location still exists. caller have free memory location - messy.

after fixing ... move onto next bug.

the next thing notice in function have:

if (strlen(curr) == strlen(digits))

but curr not initialised. fix next. move onto next bug.

you should step through each line thinking through how variables populated in each line.


Comments

Post a Comment

Popular posts from this blog

python - Operations inside variables -

this question has answer here: evaluating mathematical expression in string 12 answers i want make python script finds maximum possible output using 2 operations. problem says there syntax error @ 2nd last line, in b in there. how can fix it? x = 0 = int(input("1st number:")) c = int(input("2nd number:" )) e = int(input("3rd number:" )) in range(4): if == 0: b = "+" elif == 1: b = "-" elif == 2: b = "/" else: b = "*" j in range(4): if j == 0: d = "+" elif j == 1: d = "-" elif j == 2: d = "/" else: d = "*" k = b c d e print(k) if you're after variables e on single line, couldn...
Read more

Generic Map Parameter java -

i having lot of methods of type: public static list<eduusers> getdetails(class c, map<string, integer> params) { list<eduusers> details = null; session session = hibernateutil.getsessionfactory().opensession(); transaction tx = null; try { tx = session.begintransaction(); criteria cr = session.createcriteria(c); (map.entry<string, integer> entry : params.entryset()) { cr.add(restrictions.eq(entry.getkey(), entry.getvalue())); } details = cr.list(); tx.commit(); } catch (exception asd) { log.debug(asd.getmessage()); if (tx != null) { tx.commit(); } } { session.close(); } return details; } i trying have generic method them , have written far: public static <t> list<t> getdetails(class<t> c, class<t> b) { l...
Read more

arrays - What causes a java.lang.ArrayIndexOutOfBoundsException and how do I prevent it? -

what arrayindexoutofboundsexception mean , how rid of it? here code sample triggers exception: string[] name = {"tom", "dick", "harry"}; for(int = 0; i<=name.length; i++) { system.out.print(name[i] +'\n'); } your first port of call should documentation explains reasonably clearly: thrown indicate array has been accessed illegal index. index either negative or greater or equal size of array. so example: int[] array = new int[5]; int boom = array[10]; // throws exception as how avoid it... um, don't that. careful array indexes. one problem people run thinking arrays 1-indexed, e.g. int[] array = new int[5]; // ... populate array here ... (int index = 1; index <= array.length; index++) { system.out.println(array[index]); } that miss out first element (index 0) , throw exception when index 5. valid indexes here 0-4 inclusive. correct, idiomatic for statement here be: for (int index = 0; index <...
Read more