javascript - How to refactor jQuery code? -


i'm jquery study student.

i've made source code, think it's long. code needs refactoring.

this code think good, not good. want better code.

how refactor code?

1) short function
2) short actions
3) , short code

$(function() {   // setinitial   var body = $('body'),       header = body.find('.header'),       aside = body.find('.sidebar'),       content = body.find('.content'),       entry = content.find('.entry'),       footer = body.find('.footer'),       account = body.find('.site > .account');    /* add links */   $('.addlinks').click(function() {     window.open('/toolbar/popup/link', 'links add', 'width=400, height=185, scrollbars=no, status=no;');      return false;   });    /* asidebutton */   var asidesecondary = aside.find('.secondary'),       asidebutton = header.find($('.aside-button')),       asideclosebutton = aside.find($('.aside-close-button'));    asidebutton.click(function() {     if (!body.hasclass('aside-open') && ((asidesecondary.attr('aria-hidden') === 'true' || asidesecondary.attr('aria-hidden') === undefined))) {       // toggle       body.addclass('aside-open');        // visible       settimeout(function() {         aside.addclass('open');       }, 10);        // attr change       settimeout(function() {         asidesecondary.attr('aria-hidden', 'false');       }, 218);     }   });    /* asideclosebutton */   asideclosebutton.click(function() {     if (body.hasclass('aside-open') && asidesecondary.attr('aria-hidden') === 'false') {             // visible       aside.removeclass('open')        // toggle, attr change       settimeout(function() {         body.removeclass('aside-open');         asidesecondary.attr('aria-hidden', 'true');       }, 218);     }   });    /* search_none */   var currenturl = window.location.pathname,       url = currenturl.split('/');    var pagetype,       listitem = entry.find('> .article'),       tagcontent = entry.find('> .entry-article.tag');    if ($.isnumeric(url[1])) {     url[1] = 'article';   }    switch (url[1]) {     case 'tag':       // check: tagcontent.length < 1       if (tagcontent.length < 1) {         pagetype = 'list';       }       break;     case 'category':       pagetype = 'list';       break;     case 'search':       pagetype = 'list';       break;     case 'archive':       pagetype = 'list';       break;     default:   }    if (pagetype === 'list') {     // check: listitem < 1     if (listitem.length < 1) {       body.addclass('empty');     }   }    /* #################################################### */   /* ##################  devolopers! #################### */   /* #################################################### */    /* checkaccountdropdown() */   function checkaccountdropdown() {     if (!body.hasclass('account-open') && !account.hasclass('.open')) {       // toggle       body.addclass('account-open');        // visible       settimeout(function() {         account.addclass('open');       }, 10);        // attr change       settimeout(function() {         account.attr('aria-hidden', 'false');       }, 218);     } else {       // visible       account.removeclass('open');        // toggle, attr change       settimeout(function() {         body.removeclass('account-open');         account.attr('aria-hidden', 'true');       }, 218);     }   }    /* dropdownclose(el) */   function dropdownclose(el) {     // visible     settimeout(function() {       checkdropdownopen = 'close';       $(el).removeclass('open');     }, 10);      // attr change     settimeout(function() {       $(el).attr('aria-hidden', 'true');     }, 218);   }    /* dropdownopen(el) */   function dropdownopen(el) {     // visible     settimeout(function() {       checkdropdownopen = 'open';       $(el).addclass('open');     }, 10);      // attr change     settimeout(function() {       $(el).attr('aria-hidden', 'false');     }, 218);    }    /* dropdown */   var dropdown = $('.dropdown'),       dropdowntoggle = dropdown.find('.toggle'),       dropdownmenu = dropdown.find('.menu'),       checkdropdownopen = 'close';    dropdowntoggle.click(function() {     dropdownclose(dropdownmenu);      $(this).each(function() {       // setinitial       var thisdropdown = $(this).parent('.dropdown'),           thisdropdowntoggle = $(this),           thisdropdownmenu = $(this).next('.menu');        // checkaccountdropdown       if (thisdropdown.hasclass('account-dropdown')) {         checkaccountdropdown();       }        // checkdropdownmenu = open       if (!thisdropdownmenu.hasclass('open') && (thisdropdownmenu.attr('aria-hidden') === 'true' || thisdropdownmenu.attr('aria-hidden') === undefined)) {                 dropdownopen(thisdropdownmenu);       } else if (thisdropdownmenu.hasclass('open') && thisdropdownmenu.attr('aria-hidden') === 'false') {         dropdownclose(thisdropdownmenu);       }     })   });    /* login link */   var accounttoolbar = header.find('.account'),       tistorytoolbar = $('#tistorytoolbarid');    if (tistorytoolbar.length > 0) {     var toolbarlogin = tistorytoolbar.find('.tt_menubar_logout > a'),         toolbarlogintext = toolbarlogin.text(),         toolbarloginhref = toolbarlogin.attr('href');      accounttoolbar.find('.account-dropdown .menu > nav ul').append('<li><a class="primary" href="' + toolbarloginhref + '">' + toolbarlogintext + '</a>');   }    /* document click */   $(document).click(function(e) {     if (!body.hasclass('account-open') && !account.hasclass('.open')) {       // closest dropdown       if (!$(e.target).closest(dropdown).length) {         dropdownclose(dropdownmenu);       }     } else {       // closest dropdown, account       if (!$(e.target).closest(dropdown).length && !$(e.target).closest(account).length) {         dropdownclose(dropdownmenu);       }     }   }); });


Comments

Post a Comment

Popular posts from this blog

python - Operations inside variables -

this question has answer here: evaluating mathematical expression in string 12 answers i want make python script finds maximum possible output using 2 operations. problem says there syntax error @ 2nd last line, in b in there. how can fix it? x = 0 = int(input("1st number:")) c = int(input("2nd number:" )) e = int(input("3rd number:" )) in range(4): if == 0: b = "+" elif == 1: b = "-" elif == 2: b = "/" else: b = "*" j in range(4): if j == 0: d = "+" elif j == 1: d = "-" elif j == 2: d = "/" else: d = "*" k = b c d e print(k) if you're after variables e on single line, couldn...
Read more

Generic Map Parameter java -

i having lot of methods of type: public static list<eduusers> getdetails(class c, map<string, integer> params) { list<eduusers> details = null; session session = hibernateutil.getsessionfactory().opensession(); transaction tx = null; try { tx = session.begintransaction(); criteria cr = session.createcriteria(c); (map.entry<string, integer> entry : params.entryset()) { cr.add(restrictions.eq(entry.getkey(), entry.getvalue())); } details = cr.list(); tx.commit(); } catch (exception asd) { log.debug(asd.getmessage()); if (tx != null) { tx.commit(); } } { session.close(); } return details; } i trying have generic method them , have written far: public static <t> list<t> getdetails(class<t> c, class<t> b) { l...
Read more

arrays - What causes a java.lang.ArrayIndexOutOfBoundsException and how do I prevent it? -

what arrayindexoutofboundsexception mean , how rid of it? here code sample triggers exception: string[] name = {"tom", "dick", "harry"}; for(int = 0; i<=name.length; i++) { system.out.print(name[i] +'\n'); } your first port of call should documentation explains reasonably clearly: thrown indicate array has been accessed illegal index. index either negative or greater or equal size of array. so example: int[] array = new int[5]; int boom = array[10]; // throws exception as how avoid it... um, don't that. careful array indexes. one problem people run thinking arrays 1-indexed, e.g. int[] array = new int[5]; // ... populate array here ... (int index = 1; index <= array.length; index++) { system.out.println(array[index]); } that miss out first element (index 0) , throw exception when index 5. valid indexes here 0-4 inclusive. correct, idiomatic for statement here be: for (int index = 0; index <...
Read more